mctpd: remove remote MCTP endpoints behind MCTP bridge#116
Open
jinliangw wants to merge 1 commit intoCodeConstruct:mainfrom
Open
mctpd: remove remote MCTP endpoints behind MCTP bridge#116jinliangw wants to merge 1 commit intoCodeConstruct:mainfrom
jinliangw wants to merge 1 commit intoCodeConstruct:mainfrom
Conversation
jk-ozlabs
requested changes
Sep 24, 2025
src/mctpd.c
Outdated
| return -EPROTO; | ||
| } | ||
|
|
||
| if (peer->pool_size > 0) { |
Member
There was a problem hiding this comment.
No need for the condition here, the condition in the for loop will handle this.
Contributor
Author
There was a problem hiding this comment.
Removed the check.
src/mctpd.c
Outdated
| if (peer->pool_size > 0) { | ||
| for (i = 0; i < peer->pool_size; i++) { | ||
| eid = peer->pool_start + i; | ||
| if (eid < 256 && n->peers[eid]) { |
Member
There was a problem hiding this comment.
being a uint8_t, eid will always be < 256; the case you're looking to check here will be hidden via an overflow.
If you want to check the pool end validity, you'll need to do so in a larger type.
Contributor
Author
There was a problem hiding this comment.
Good catch! Added the check if (peer->pool_start > 255 - i) to avoid uint8_t overflow.
jinliangw
force-pushed
the
remove-bridged-eid
branch
2 times, most recently
from
fa2fcba to
8593ffa
Compare
Tested: The bridged MCTP endpoints are removed when interface is removed or when MCTP bridge EID is removed. Signed-off-by: Jinliang Wang <[email protected]>
jinliangw
force-pushed
the
remove-bridged-eid
branch
from
8593ffa to
552930e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested:
The bridged MCTP endpoints are removed when interface is removed or when MCTP bridge EID is removed.